Read raw bytes for routes of byte[] inputs, bypassing JSON marshalling #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a special case for routes of type
byte[] -> Async<'t>where the input bytes are sent as binary content to the server and are read directly from the input request body stream, thus bypassing unnecessary JSON marshalling.Fable client proxy sends
Content-Type: application/octet-streamheader along such requests that the server can intercept and reads the request stream while maintaining backwards-compatibility with old clients sending byte[] that goes through JSON marshalling pipeline.Fixes #116 and completes the binary responses PR #117