Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing SVG elements/attributes #188

Merged
merged 9 commits into from
May 9, 2020
Merged

Add missing SVG elements/attributes #188

merged 9 commits into from
May 9, 2020

Conversation

Shmew
Copy link
Collaborator

@Shmew Shmew commented May 9, 2020

Helps further fix #174, resolves #184, and potentially resolves #148.

@Shmew Shmew requested a review from Zaid-Ajaj May 9, 2020 19:08
Copy link
Owner

@Zaid-Ajaj Zaid-Ajaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really awesome stuff @Shmew ❤️ I only saw a few minor things that you might want to review, the rest looks great!

Feliz/Properties.fs Outdated Show resolved Hide resolved
Feliz/Properties.fs Outdated Show resolved Hide resolved
Feliz/Properties.fs Outdated Show resolved Hide resolved
@Shmew Shmew requested a review from Zaid-Ajaj May 9, 2020 22:23
@Zaid-Ajaj Zaid-Ajaj merged commit aaeb36f into master May 9, 2020
@Shmew Shmew deleted the finish-svg branch May 10, 2020 00:03
@Zaid-Ajaj Zaid-Ajaj mentioned this pull request May 14, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finish SVG elements and attributes Can't set IFrame and SVG attributes Towards v1.0
2 participants