Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in #define for ESP8266 #32

Closed
delboy711 opened this issue Dec 13, 2018 · 2 comments
Closed

Typo in #define for ESP8266 #32

delboy711 opened this issue Dec 13, 2018 · 2 comments
Assignees
@SV-Zanshin
Labels
bug Something isn't working

Comments

@delboy711
Copy link

After a break, I am back working with INA devices. This time using ESP8266 processors, and have found another issue

In INA.cpp there is a typo on line 186
#if defined(ESP32) || defined(ESP2866)
should read
#if defined(ESP32) || defined(ESP8266)

The typo causes problems if there is more than one INA device.

The same typo is present in library.properties line 9
This causes the Arduino IDE to throw up a warning when compiling.

Thanks

Derek
@SV-Zanshin SV-Zanshin self-assigned this Dec 13, 2018
@SV-Zanshin SV-Zanshin added the bug Something isn't working label Dec 13, 2018
@SV-Zanshin
Copy link
Collaborator

Understood and fixing

SV-Zanshin pushed a commit that referenced this issue Dec 13, 2018
Issue #32
bc4da30 
Fixed
@SV-Zanshin
Copy link
Collaborator

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SV-Zanshin SV-Zanshin

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@delboy711 @SV-Zanshin