Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getId() to return dec/Hex value of the Id #38

Closed
novski opened this issue Feb 8, 2019 · 5 comments
Closed

getId() to return dec/Hex value of the Id #38

novski opened this issue Feb 8, 2019 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@novski
Copy link

novski commented Feb 8, 2019

Is your feature request related to a problem? Please describe.
i can not allways determine which INA219 is read as Id's are incrementaly created.

Describe the solution you'd like
I wold like to see the example displayreadings.ino to show the Hexadecimal or Decimal id of the read shunt.

Describe alternatives you've considered
Don't know if thats possible. No alternatives.

Additional context
bildschirmfoto 2019-02-08 um 13 39 38

bildschirmfoto 2019-02-08 um 13 41 24

@SV-Zanshin SV-Zanshin self-assigned this Feb 8, 2019
@SV-Zanshin
Copy link
Collaborator

That should be possible to add. Let me look into that.

@SV-Zanshin SV-Zanshin added the enhancement New feature or request label Feb 8, 2019
SV-Zanshin pushed a commit that referenced this issue Feb 9, 2019
@SV-Zanshin
Copy link
Collaborator

I have added a new library method, "getDeviceAddress()" which returns the device's I2C address. I've also updated the DisplayReadings.ino example program to include displaying the address. Unfortunately, I cannot find my breadboard which has all the different I2C devices installed for testing.

Although this change was trivial, I would appreciate it if you could do the test to see if it functions correctly and post the results to this issue.

Thanks.

@SV-Zanshin
Copy link
Collaborator

I've also changed the comments around in the library, moving all the doxygen comments from the .h to the .cpp

SV-Zanshin pushed a commit that referenced this issue Feb 10, 2019
Cleaned up output to line up regardless of length
@SV-Zanshin
Copy link
Collaborator

I found my INA226 lying around and checked the changes.

@novski
Copy link
Author

novski commented Feb 10, 2019

Hi, im sorry i was not available shortly.
I now checked on my side as well and it works great.
Decimal Address is the best choice! Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants