inconsistent unit on setBusConversion #19
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On
setBusConversion
andsetShuntConversion
should the unit forconvTime
parameter μs.Therefore, the if/else clauses for the higher 4 ranges of the INA226 correspond to 82.440 μs,
41.560 μs, 21.160 μs and 11.000 μs. which is one order of magnitude higher than the values on Tables 7 and 8 on the datasheet.
Fixes #18
** PLEASE NOTE ** that this PR is targeted to the master branch. If I should target other branch, just met me know and I'll work it out.
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: