Test bed for new pull #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added special register bits by name.
Added functions to set/read/write specific bits into registers.
Moved alarm polarity setting to separate function setAlarmPolarity(const bool polarity) (so not to break existing uses of this libary).
Optimised the setAlarm function.
Changes in many functions that deal with setting/clearing/reading/writing single bits to the registers.
Removed the wire.available() calls as they're redundant (the number of bytes is guaranteed by wire.requestFrom()).
Marked a few FIXMEs at places that need attention.
* Updated, tested/corrected setAlarm().
Updated, tested setAlarmPolarity().
Updated, tested weekdayRead() & weekdayWrite(const uint8_t dow).
Fixed bug in dayOfTheWeek() - it was a day off due to incorrect calculation.
Updated getMFP() to allow for the other options. Returns value 0-3:
0 = pin set LOW.
1 = pin set HIGH.
2 = pin controlled by alarms.
3 = pin controlled by square wave output.
Updated, tested setMFP().
Updated, tested setSQWSpeed(). Added support for 64 Hz square wave output.
Updated, tested getPowerFail() & clearPowerFail().
The new pull had problems with regression. Example jobs no longer ran or no longer ran correctly. Fixed issues introduced in pull and also corrected issues encountered when writing more then 32 bytes to the MCP7940 using the library methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes needed to be done to the merged pull in order for the existing example jobs to run correctly