-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking/modify tokens values and add tokens #430
Merged
veronicavannini
merged 15 commits into
master
from
chore/modify-tokens-values-and-add-tokens
May 15, 2024
Merged
breaking/modify tokens values and add tokens #430
veronicavannini
merged 15 commits into
master
from
chore/modify-tokens-values-and-add-tokens
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaoloFrancesco-Marino
approved these changes
May 9, 2024
Andrebbe aggiornato il documento |
package.json
Outdated
@@ -42,7 +42,7 @@ | |||
"@types/react-dom": "^17.0.0" | |||
}, | |||
"dependencies": { | |||
"@zanichelli/albe-design-tokens": "^0.2.36", | |||
"@zanichelli/albe-design-tokens": "^1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meglio indicare la 1.0.1
anche qui, visto che la 1.0.0
mi pare incompleta.
francesco-santi-1
approved these changes
May 15, 2024
delete-merged-branch
bot
deleted the
chore/modify-tokens-values-and-add-tokens
branch
May 15, 2024 14:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking - replace tokens names
Motivation and Context
Change some tokens names and values referring to text, disabled and icon.
List of changed icons:
Priority
Types of changes
Note
https://www.figma.com/file/w51ZwDwLNEt0yamar2sRRQ/branch/focaaS8G5UGlMUzz1wjaYo/Nuovi-Componenti-e-Pattern?type=design&node-id=6149-2&mode=design&t=eHHlDAkbImUBIpL1-0