Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking/modify tokens values and add tokens #430

Merged
merged 15 commits into from
May 15, 2024

Conversation

veronicavannini
Copy link
Collaborator

@veronicavannini veronicavannini commented May 7, 2024

Breaking - replace tokens names

Motivation and Context

Change some tokens names and values referring to text, disabled and icon.

List of changed icons:

  • text01 renamed default-text
  • text02 changed to text01 when necessary
  • text04 renamed inverse-text
  • disabled02 changed to disabled03 when necessary
  • icon02 renamed default-icon
  • icon03 renamed inverse-icon
  • icon01 renamed primary01-icon

Priority

  • 1 - Highest
  • 2 - High
  • 3 - Medium
  • 4 - Low
  • 5 - Lowest
  • 6 - Not a Priority

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Component (add a Component as approved by Design System)
  • Docs (add documentation)
  • Chore (changes that adds small enhancement)
  • Breaking (fix or feature that would cause existing functionality to not work as expected)

Note

https://www.figma.com/file/w51ZwDwLNEt0yamar2sRRQ/branch/focaaS8G5UGlMUzz1wjaYo/Nuovi-Componenti-e-Pattern?type=design&node-id=6149-2&mode=design&t=eHHlDAkbImUBIpL1-0

@francesco-santi-1
Copy link
Collaborator

Andrebbe aggiornato il documento MIGRATION.md, indicando cosa cambia con la nuova versione.

package.json Outdated
@@ -42,7 +42,7 @@
"@types/react-dom": "^17.0.0"
},
"dependencies": {
"@zanichelli/albe-design-tokens": "^0.2.36",
"@zanichelli/albe-design-tokens": "^1.0.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meglio indicare la 1.0.1 anche qui, visto che la 1.0.0 mi pare incompleta.

@veronicavannini veronicavannini merged commit 85f9c90 into master May 15, 2024
3 of 4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the chore/modify-tokens-values-and-add-tokens branch May 15, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants