Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly nest tsconfig under compilerOptions #135

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Conversation

stevekrouse
Copy link
Contributor

@stevekrouse stevekrouse commented Mar 16, 2022

This PR was started to emit .d.ts files (#116) but the solution involved fixing other issues with the tsconfig. Basically we were using attributes at the top level that should all be nested under compilerOptions.

Closes #116

@janpaul123 janpaul123 temporarily deployed to zaplib-pr-135 March 16, 2022 01:02 Inactive
@stevekrouse
Copy link
Contributor Author

What we used to output in the dist folder:

Screen Shot 2022-03-15 at 6 06 09 PM

What we output with these changes:

Screen Shot 2022-03-15 at 6 04 23 PM

This works as long as you import from the .js file. It doesn't work if you import from the .production.js or the .development.js versions.

@stevekrouse
Copy link
Contributor Author

I think it's ready to go :)

Copy link
Contributor

@janpaul123 janpaul123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update some documentation? E.g. in particular it might be useful to mention how the .production.js vs .js works (by itself, and how the Typescript definitions only work with the .js version)

@janpaul123 janpaul123 temporarily deployed to zaplib-pr-135 March 16, 2022 22:37 Inactive
@janpaul123 janpaul123 temporarily deployed to zaplib-pr-135 March 17, 2022 00:38 Inactive
@stevekrouse stevekrouse merged commit 235fa42 into main Mar 17, 2022
@stevekrouse stevekrouse deleted the fix-tsconfig branch March 17, 2022 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Typescript definitions in package distribution
2 participants