fix(app-token-template): Early return when supply is zero (#2770)

src/apps/arrakis/common/arrakis.pool.token-fetcher.ts

@@ -74,7 +74,7 @@ export abstract class ArrakisPoolTokenFetcher extends AppTokenTemplatePositionFe
     const reservesRaw = await contract.getUnderlyingBalances();
     const reserves = reservesRaw.map((r, i) => Number(r) / 10 ** appToken.tokens[i].decimals);
     const pricePerShare = reserves.map(r => {
-      return r == 0 ? 0 : r / appToken.supply;
+      return r / appToken.supply;
     });
     return pricePerShare;
   }

src/apps/balancer-v1/ethereum/balancer-v1.pool.token-fetcher.ts

@@ -85,7 +85,6 @@ export class EthereumBalancerV1PoolTokenFetcher extends AppTokenTemplatePosition
   }
 
   async getPricePerShare({ contract, appToken }: GetPricePerShareParams<BalancerPoolToken>) {
-    if (appToken.supply === 0) return appToken.tokens.map(() => 0);
     const reservesRaw = await Promise.all(appToken.tokens.map(t => contract.getBalance(t.address)));
     const reserves = reservesRaw.map((r, i) => Number(r) / 10 ** appToken.tokens[i].decimals);
     const pricePerShare = reserves.map(r => r / appToken.supply);

src/apps/bancor-v3/ethereum/bancor-v3.pool.token-fetcher.ts

@@ -54,8 +54,6 @@ export class EthereumBancorV3PoolTokenFetcher extends AppTokenTemplatePositionFe
     multicall,
     appToken,
   }: GetPricePerShareParams<PoolToken, DefaultAppTokenDataProps, DefaultAppTokenDefinition>) {
-    if (appToken.supply === 0) return [0];
-
     const bancorContract = this.contractFactory.bancorNetwork({ address: this.bancorAddress, network: this.network });
     const poolCollectionAddress = (await multicall.wrap(bancorContract).poolCollections()).at(-1)!;
     const poolContract: PoolCollection = this.contractFactory.poolCollection({

src/apps/bastion-protocol/aurora/bastion-protocol.pool.token-fetcher.ts

@@ -78,7 +78,6 @@ export class AuroraBastionProtocolPoolTokenFetcher extends AppTokenTemplatePosit
     multicall,
     appToken,
   }: GetPricePerShareParams<Erc20, DefaultAppTokenDataProps, BastionProtocolPoolTokenDefinition>) {
-    if (appToken.supply === 0) return [0, 0];
     const swapContract = this.contractFactory.bastionProtocolSwap({
       address: definition.swapAddress,
       network: this.network,

src/apps/curve/common/curve.pool-dynamic.token-fetcher.ts

@@ -146,8 +146,6 @@ export abstract class CurvePoolDynamicTokenFetcher<T extends Contract> extends A
     definition,
     appToken,
   }: GetPricePerShareParams<Erc20, CurvePoolTokenDataProps, CurvePoolDefinition>) {
-    if (appToken.supply === 0) return appToken.tokens.map(() => 0);
-
     const contract = multicall.wrap(this.resolveRegistry(this.registryAddress));
     const swapAddress = definition.swapAddress;
     const reservesRaw = await this.resolveReserves({ contract, swapAddress, multicall });

src/apps/enzyme-finance/ethereum/enzyme-finance.vault.token-fetcher.ts

@@ -62,8 +62,6 @@ export class EthereumEnzymeFinanceVaultTokenFetcher extends AppTokenTemplatePosi
     appToken,
     multicall,
   }: GetPricePerShareParams<EnzymeFinanceVault, DefaultAppTokenDataProps, DefaultAppTokenDefinition>) {
-    if (appToken.supply === 0) return appToken.tokens.map(() => 0);
-
     const reserves = await Promise.all(
       appToken.tokens.map(async token => {
         const uTokenContract = this.contractFactory.erc20({ address: token.address, network: this.network });

src/apps/pancakeswap/common/pancakeswap.pool-dynamic.token-fetcher.ts

@@ -132,8 +132,6 @@ export abstract class PancakeswapPoolDynamicTokenFetcher<
     definition,
     appToken,
   }: GetPricePerShareParams<Erc20, PancakeswapPoolTokenDataProps, PancakeswapPoolDefinition>) {
-    if (appToken.supply === 0) return appToken.tokens.map(() => 0);
-
     const contract = multicall.wrap(this.resolveStablePool(definition.swapAddress));
     const reservesRaw = await this.resolveReserves({ contract, multicall });
 

src/apps/rigoblock/common/rigoblock.pool.token-fetcher.ts

@@ -131,8 +131,6 @@ export abstract class RigoblockPoolTokenFetcher extends AppTokenTemplatePosition
     appToken,
     multicall,
   }: GetPricePerShareParams<SmartPool, DefaultAppTokenDataProps, RigoblockSmartPoolDefinition>) {
-    if (appToken.supply === 0) return appToken.tokens.map(() => 0);
-
     const reserves = await Promise.all(
       appToken.tokens.map(async token => {
         const uTokenContract = this.contractFactory.erc20({ address: token.address, network: this.network });
@@ -142,9 +140,7 @@ export abstract class RigoblockPoolTokenFetcher extends AppTokenTemplatePosition
       }),
     );
 
-    return reserves.map(r => {
-      return r == 0 ? 0 : r / appToken.supply;
-    });
+    return reserves.map(r => r / appToken.supply);
   }
 
   async getLabel({

src/apps/unipilot/common/unipilot.vault.token-fetcher.ts

@@ -79,9 +79,7 @@ export abstract class UnipilotVaultTokenFetcher extends AppTokenTemplatePosition
     const { totalLockedToken0, totalLockedToken1 } = definition;
     const reservesRaw = [totalLockedToken0, totalLockedToken1];
     const reserves = reservesRaw.map((r, i) => Number(r) / 10 ** appToken.tokens[i].decimals);
-    const pricePerShare = reserves.map(r => {
-      return r == 0 ? 0 : r / appToken.supply;
-    });
+    const pricePerShare = reserves.map(r => r / appToken.supply);
     return pricePerShare;
   }
 

src/position/template/app-token.template.position-fetcher.ts

@@ -265,6 +265,7 @@ export abstract class AppTokenTemplatePositionFetcher<
           ]);
 
           const supply = Number(totalSupplyRaw) / 10 ** decimals;
+          if (supply === 0) return null;
 
           // Resolve price per share stage
           const pricePerShareStageFragment = { ...baseFragment, symbol, decimals, supply };