Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

fix(cache): Cache improvements #260

Merged
merged 4 commits into from Apr 25, 2022
Merged

fix(cache): Cache improvements #260

merged 4 commits into from Apr 25, 2022

Conversation

JForsaken
Copy link
Contributor

@JForsaken JForsaken commented Apr 25, 2022

Description

  • Removes ENABLED_HELPERS in favor of API_RESOLVED_POSITIONS (ex: API_RESOLVED_POSITIONS=curve). This lets you control whether you want positions to be resolved by the API or from Studio. Useful when circular deps on positions are present
  • TTL should not be applicable on studio. When the cache can be primed, set it, and update it on interval. The cache should not expire (better dev experience)

Checklist

API_RESOLVED_POSITIONS=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding some docs related to this parameter and why we would use it?

@JForsaken JForsaken merged commit a90887c into main Apr 25, 2022
@JForsaken JForsaken deleted the cache-fixes branch April 25, 2022 17:16
This was referenced Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants