Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

King's Rock in GSC #3343

Closed
FredrIQ opened this issue Mar 7, 2017 · 5 comments
Closed

King's Rock in GSC #3343

FredrIQ opened this issue Mar 7, 2017 · 5 comments

Comments

@FredrIQ
Copy link

FredrIQ commented Mar 7, 2017

Contrary to what Bulbapedia claims, and what Showdown does (inherited by gen3), King's Rock in GSC isn't merely restricted to moves without secondary effects. GSC move effects in general are implemented as "move scripts" with different commands doing different things. One of these is (in pret) labeled kingsrock, which allows King's Rock to proc for said move. This seems to be placed rather arbitrarily, so I will just list the attacking move effects that doesn't do this (Doing the reverse would list quite a lot of things...):

  • Attacks that poison (not Twineedle which does proc King's Rock), burn, freeze, paralyze, including Tri Attack, Flame Wheel, Sacred Fire, Thunder
  • Dream Eater
  • Attacks that increase your or decrease target stats
  • Moves that flinch, including Twister but not Snore
  • Moves that confuse
  • Hyper Beam
  • Partially trapping moves
  • Earthquake
  • Future Sight
  • Gust

Moves affected by King's Rock that might seem odd

  • Bide
  • Counter/Mirror Coat

Other things to consider:

  • Multi-hit moves (including Twineedle) only has a single roll for King's Rock
  • King's Rock's flinch rate is 30/256
  • If the target is asleep (or frozen, but GSC unfreeze is an endturn effect), you can't flinch the target. This doesn't apply to King's Rock which can still flinch as usual

To see for yourselves which moves this concerns, in case something is unclear -- https://github.com/pret/pokecrystal/blob/master/battle/moves/move_effects.asm

@FredrIQ
Copy link
Author

FredrIQ commented Mar 7, 2017

After discussing with people over at Bulbapedia and consulting other sources, when it comes to moves affected, this is in fact not merely limited to GSC -- King's Rock before 5gen in general relied on move flags (not flags per se in at least GSC, but it can effectively be treated as one), and 2gen, 3gen and 4gen are all different. See http://upcarchive.playker.info/0/upokecenter/content/pokemon-ruby-version-sapphire-version-and-emerald-version-list-of-moves.html for 3gen (there's also a page for 4gen for similar reasons). Note that the rate should be correct as of 3gen, it's only in 2gen where it's different (30/256 as said) and only GSC has the flinch inconsistency.

@asingh04
Copy link

can this issue be taken up as a first/starting issue for me? is anyone working on it?

@Zarel
Copy link
Member

Zarel commented May 16, 2018

As far as I know, this isn't taken yet. Feel free!

@bgsamm
Copy link
Contributor

bgsamm commented Oct 15, 2018

How does Snore interact with King's Rock in Gen 2, since it already has a chance to flinch? Is the rate from King's Rock added on to Snore's?

@Marty-D
Copy link
Collaborator

Marty-D commented Oct 24, 2018

Fixed in #4916!

@Marty-D Marty-D closed this as completed Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants