Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More HTTP stuff #21

Merged
merged 4 commits into from Dec 18, 2023
Merged

More HTTP stuff #21

merged 4 commits into from Dec 18, 2023

Conversation

Zastai
Copy link
Owner

@Zastai Zastai commented Dec 18, 2023

This adds Copy methods to HttpUtils, for copying HTTP header collections.

It also adjusts HttpError:

  • it now retains the URI and headers for the request that provoked the error response (if available)
  • it now has only a single constructor, which also allows specifying a message for the exception

@Zastai
Add utility methods for copying header collections
4c8840d 
These are now used by `HttpError.FromResponseAsync`.

Because this adds new API, the project version is bumped up (to
2.2.0-pre).
@Zastai
Drop #define TRACE
dcb6700 
It seems to be implied by the .NET SDK; when that changes, it probably
makes more sense to add it to our own SDK.
@Zastai
Retain request URI and headers in HttpError
d8a42e9 
This also tweaks the XML doc comments slightly.
@Zastai
Consolidate HttpError constructors
18f357e 
There is now only a single constructor, with default parameter values.
It adds a `message` parameter to allow overriding the full message; the
message form that was previously produced by the `Message` property will
now be computed once at construction time when no explicit message is
provided.

This is an API break, so the version was bumped to 3.0.0-pre.
@Zastai Zastai added breaking An incompatible change to a feature or API (requires a bump of the major version) feature A new feature or API was added (requires a bump of the minor version) labels Dec 18, 2023
@Zastai Zastai self-assigned this Dec 18, 2023
@Zastai Zastai merged commit 9a6389b into main Dec 18, 2023
2 checks passed
@Zastai Zastai deleted the more-http-stuff branch December 18, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Zastai Zastai

Labels
breaking An incompatible change to a feature or API (requires a bump of the major version) feature A new feature or API was added (requires a bump of the minor version)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Zastai