Handle HTTP error responses #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`WebRequest` used to throw `WebException` when an HTTP response had an error status. The library was changed to use `HttpClient` instead, which does not do that, but the code was not updated to handle error responses. Error handling has now been re-added, using a new `HttpError` exception. The XML doc comments were updated accordingly. In addition, new methods have been added: `FetchReleaseIfAvailable` and `FetchGroupReleaseIfAvailable` (plus async versions). These will return `null` instead of throwing an `HttpError` when a 404 response is received. Bumped version to 5.1.0-pre due to the new methods. Fixes #41.
Zastai
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebRequestused to throwWebExceptionwhen an HTTP response had an error status. The library was changed to useHttpClientinstead, which does not do that, but the code was not updated to handle error responses.Error handling has now been re-added, using a new
HttpErrorexception. The XML doc comments were updated accordingly.In addition, new methods have been added:
FetchReleaseIfAvailableandFetchGroupReleaseIfAvailable(plus async versions). These will returnnullinstead of throwing anHttpErrorwhen a 404 response is received.Bumped version to 5.1.0-pre due to the new methods.
Fixes #41.