Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silverstripe 3 #2

Closed
wants to merge 11 commits into from

Conversation

lx-berlin
Copy link

nothing fancy. maybe u will find something usefull.

@Zauberfisch
Copy link
Owner

thanks for all that stuff, sorry it took me so long to get to look at it.
I've started going through the pull request and apply some changes by hand.

there are a few things though:

  • the netefxTools should be a own module, then we can add it as submodule
  • not sure, but I think we should do the same for google analytics see add Google Analytics #7
  • from what I saw you added bootstrap, I haven't used bootstrap yet, do we need it?
  • you created a theme folder, I don't like theme folders :D is there a special need for the theme folder?

@lx-berlin
Copy link
Author

  • sure, netefxTools could be an extra module (i dont know what extra tools i
    am going to add there anyway)

  • we built some pages with bootstrap, but not yet in combination with SS3.
    But i think we will (as soon as 3 is stable enough). So i want to keep it in
    the boilerplate repo.

  • i had an error message when installing the blog module with the previos
    version of ss boilerplate. The problem appeared because of a function (i
    dont remember the funtion name) in the blogmodule.
    The blogmodule was searching for the current themes but couldnt find one.
    So i decided to revert everything to a separated /themes folder and the
    error was gone.
    I was fearing that removing the themes/ folder might cause some more problem
    with other modules in the future.


From: Zauberfisch [mailto:notifications@github.com]
Sent: Samstag, 11. August 2012 11:14
To: Zauberfisch/silverstripe-boilerplate
Cc: lx-berlin
Subject: Re: [silverstripe-boilerplate] Silverstripe 3 (#2)

thanks for all that stuff, sorry it took me so long to get to look at it.
I've started going through the pull request and apply some changes by hand.

there are a few things though:

  • the netefxTools should be a own module, then we can add it as
    submodule
  • not sure, but I think we should do the same for google analytics see
    add Google Analytics #7 add Google Analytics #7
  • from what I saw you added bootstrap, I haven't used bootstrap yet,
    do we need it?
  • you created a theme folder, I don't like theme folders :D is there a
    special need for the theme folder?

Reply to this email directly or view
<#2 (comment)
-7665231> it on GitHub.

<https://github.com/notifications/beacon/HWJB8BRfYILShHM86kj3n4bSUf38zfl0JNG
PEcJrWbhRkronfeOunks5jeSKQjJL.gif>

@Zauberfisch
Copy link
Owner

hmmm, bootstrap, ok, I will take a look at it, never used it


ah, I see your point, but I consider this a bug in the blog module, and not in the boilerplate
The silverstripe framework is built to function without a theme folder, modules should not depend on the theme folder

I will take a look at it and submit a bug report to the blog module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants