Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rand_core to 0.6 and rand to 0.8 #44

Merged
merged 1 commit into from Mar 30, 2021
Merged

Update rand_core to 0.6 and rand to 0.8 #44

merged 1 commit into from Mar 30, 2021

Conversation

dconnolly
Copy link
Contributor

No description provided.

@teor2345
Copy link
Contributor

Looks like a duplicate of #42 @dconnolly ?

@dconnolly
Copy link
Contributor Author

Looks like a duplicate of #42 @dconnolly ?

I reverted that merge as I realized that would be a backwards-incompatible API change, requiring a major version update. But looking at #40, now that we checkpoint on Canopy, I guess we don't need to worry about the 1.0 series anymore, and just bump to 3.0?

@teor2345
Copy link
Contributor

Looks like a duplicate of #42 @dconnolly ?

I reverted that merge as I realized that would be a backwards-incompatible API change, requiring a major version update. But looking at #40, now that we checkpoint on Canopy, I guess we don't need to worry about the 1.0 series anymore, and just bump to 3.0?

As long as we don't change the 1.x branch (the pre-Canopy branch), we can do whatever we like to the main branch.

And for Zebra specifically, we should only be using the main branch.

I'm not sure if anyone else is using our fork of ed25519-zebra.

@dconnolly dconnolly linked an issue Mar 30, 2021 that may be closed by this pull request
@dconnolly
Copy link
Contributor Author

Looks like this does not in fact require our dependency curve25519-dalek to support the same version of rand/rand_core: we abstract it away, use rand/rand_core, and pass the resulting bytes to any -dalek types. Merging, created #45 to do the 3.0 release soon.

@dconnolly dconnolly merged commit 539fad0 into main Mar 30, 2021
@dconnolly dconnolly deleted the rand branch March 30, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to rand_core 0.6
2 participants