Skip to content

Commit

Permalink
Fix trusted dealer participant identifier output to be a hex encoded …
Browse files Browse the repository at this point in the history
…string (#32)
  • Loading branch information
natalieesk committed Jun 23, 2023
1 parent 34c22f2 commit 21b5588
Show file tree
Hide file tree
Showing 5 changed files with 149 additions and 71 deletions.
83 changes: 62 additions & 21 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion trusted-dealer/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ edition = "2021"
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
frost-ed25519 = "0.4.0"
frost-ed25519 = { path = "../../frost/frost-ed25519/" }
thiserror = "1.0"
rand = "0.8"
hex = "0.4"
Expand Down
13 changes: 8 additions & 5 deletions trusted-dealer/src/output.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,22 +26,25 @@ pub fn print_values(
) {
logger.log(format!(
"Group public key: {:x?}",
hex::encode(pubkeys.group_public.to_bytes())
hex::encode(pubkeys.group_public().to_bytes())
));

println!("---");

for (k, v) in keys.iter().sorted_by_key(|x| x.0) {
logger.log(format!("Participant {:?}", k));
logger.log(format!(
"Participant: {:?}",
hex::encode(Identifier::serialize(k))
));
logger.log(format!(
"Secret share: {:?}",
hex::encode(v.value.to_bytes())
hex::encode(v.value().to_bytes())
));
logger.log(format!(
"Public key: {:?}",
hex::encode(pubkeys.signer_pubkeys[k].to_bytes())
hex::encode(pubkeys.signer_pubkeys()[k].to_bytes())
));
logger.log(format!("Commitment: {}", encode_commitment(&v.commitment)));
logger.log(format!("Commitment: {}", encode_commitment(v.commitment())));
println!("---")
}
}
Expand Down
16 changes: 8 additions & 8 deletions trusted-dealer/src/tests/integration_test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ fn check_keygen_with_dealer() {
signature_gen::generate_nonces_and_commitments(config.min_signers, &key_packages, &mut rng);
let message = "message to sign".as_bytes();
let comms = commitments.into_values().collect();
let signing_package = frost::SigningPackage::new(comms, message.to_vec());
let signing_package = frost::SigningPackage::new(comms, message);
let signature_shares =
signature_gen::generate_signature_shares(nonces, &key_packages, &signing_package);
let group_signature =
frost::aggregate(&signing_package, &signature_shares[..], &pubkeys).unwrap();
let verify_signature = pubkeys.group_public.verify(message, &group_signature);
let verify_signature = pubkeys.group_public().verify(message, &group_signature);

assert!(verify_signature.is_ok());
}
Expand All @@ -45,12 +45,12 @@ fn check_keygen_with_dealer_with_large_num_of_signers() {
signature_gen::generate_nonces_and_commitments(config.min_signers, &key_packages, &mut rng);
let message = "message to sign".as_bytes();
let comms = commitments.into_values().collect();
let signing_package = frost::SigningPackage::new(comms, message.to_vec());
let signing_package = frost::SigningPackage::new(comms, message);
let signature_shares =
signature_gen::generate_signature_shares(nonces, &key_packages, &signing_package);
let group_signature =
frost::aggregate(&signing_package, &signature_shares[..], &pubkeys).unwrap();
let verify_signature = pubkeys.group_public.verify(message, &group_signature);
let verify_signature = pubkeys.group_public().verify(message, &group_signature);

assert!(verify_signature.is_ok());
}
Expand All @@ -76,12 +76,12 @@ fn check_keygen_with_dealer_with_secret() {
);
let message = "message to sign".as_bytes();
let comms = commitments.into_values().collect();
let signing_package = frost::SigningPackage::new(comms, message.to_vec());
let signing_package = frost::SigningPackage::new(comms, message);
let signature_shares =
signature_gen::generate_signature_shares(nonces, &key_packages, &signing_package);
let group_signature =
frost::aggregate(&signing_package, &signature_shares[..], &pubkeys).unwrap();
let verify_signature = pubkeys.group_public.verify(message, &group_signature);
let verify_signature = pubkeys.group_public().verify(message, &group_signature);

assert!(verify_signature.is_ok());
}
Expand All @@ -107,12 +107,12 @@ fn check_keygen_with_dealer_with_secret_with_large_num_of_signers() {
);
let message = "message to sign".as_bytes();
let comms = commitments.into_values().collect();
let signing_package = frost::SigningPackage::new(comms, message.to_vec());
let signing_package = frost::SigningPackage::new(comms, message);
let signature_shares =
signature_gen::generate_signature_shares(nonces, &key_packages, &signing_package);
let group_signature =
frost::aggregate(&signing_package, &signature_shares[..], &pubkeys).unwrap();
let verify_signature = pubkeys.group_public.verify(message, &group_signature);
let verify_signature = pubkeys.group_public().verify(message, &group_signature);

assert!(verify_signature.is_ok());
}
Loading

0 comments on commit 21b5588

Please sign in to comment.