Add refresh shares with dealer functionality #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradoplg
requested changes
May 30, 2024
conradoplg
requested changes
Jun 12, 2024
conradoplg
reviewed
Jun 17, 2024
|
Visit the preview URL for this PR (updated for commit 1f0d92f): https://frost-book--pr665-refresh-shares-245-2l1szvtq.web.app (expires Wed, 24 Jul 2024 09:34:45 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b7f43333fbf8fa5527ab3f0dd7bd10bb1fa7401c |
Split refresh_shares_with_dealer into calculate_zero_key and refresh_share
Add serialisation test
Fixed some typos
Diagram is still to be added
natalieesk
force-pushed
the
refresh_shares_245
branch
from
71666ea
to
42f3ebe
Compare
conradoplg
requested changes
Jul 9, 2024
There was a problem hiding this comment.
Looks good, thanks! It just needs fixing CI which requires just changing the import of Vec.
I'm just not sure about the calculate_zero_key name. I don't think the user should care about the fact that involves the zero key. Maybe something like compute_refreshing_shares?
There's some places where I think we can make the code a bit clearer but I think I'll create a PR after this one merges and we can then discuss it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #245