Relax cc dep, bump bindgen (Apple M1 support) #20
Conversation
|
Awesome! Testing in zebra on mah new M1 💻 |
|
zebra will require additional updates like rocksdb, ring. I'll submit PR there shortly. |
.github/workflows/ci.yml
Outdated
| shell: powershell | ||
| run: | | ||
| iex (new-object net.webclient).downloadstring('https://get.scoop.sh') | ||
| scoop install llvm --global |
There was a problem hiding this comment.
Is there any specific reason to switch to scoop here?
Zebra's CI still uses chocolatey, and in general we'd like to limit the number of CI dependencies.
There was a problem hiding this comment.
One of the advantages of scoop that LLVM installed within 30s compare to almost 200s with chocolatey :(
I'll switch back to chocolatey with env fixes.
There was a problem hiding this comment.
One of the advantages of
scoopthat LLVM installed within 30s compare to almost 200s withchocolatey:(
Wow that is a big difference. It would be very useful for our engineers to have 3 minutes faster CI builds.
As long as scoop has decent uptime, I'd be happy to take separate PRs to switch to scoop for:
- zebra
- zcash_script
- ed25519-zebra
and anything else we're actively developing. (@dconnolly will know if there are any extra crypto crates that we should switch over now.)
I'd like a separate PR so we don't block crate dependency changes on CI environment changes.
|
Just waiting on @dconnolly to confirm this works, then we can merge. (Thanks for submitting those 3 PRs - sorry they have dependencies. We'll try to get them all merged as quick as possible.) |
|
Confirmed on my M1 ✅ |
bindgenfix M1 issue in 0.58.0: https://github.com/rust-lang/rust-bindgen/blob/master/CHANGELOG.md#0580 (AArch64 bug)ccwas pinned in 6c5cc47#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542 butrust-secp256k1do not restrictccanymore: rust-bitcoin/rust-secp256k1@fd8b3ff#diff-45481f3ec5a7270ec2be00f4ce78c833c29070204eb195bac332377b0d63299b Also ring:0.16.17 (minimal version which support Apple M1) requirecc >= 1.0.62.