Update to zcash 5.2.0 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-subtree-dir: depend/zcash git-subtree-split: f98166f7f556ee9b9f597d45275c32843a87b0b6
conradoplg
force-pushed
the
update-5.2.0
branch
from
77c2fb8
to
9d36477
Compare
teor2345
requested changes
Aug 21, 2022
conradoplg
force-pushed
the
update-5.2.0
branch
from
b928948
to
0ccbbba
Compare
conradoplg
force-pushed
the
update-5.2.0
branch
from
0ccbbba
to
aee0aee
Compare
I ended up removing Windows support and opening #38 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ZcashFoundation/zebra#4767 we need to update zcash_script to use the latest zcash sources, since we must use the same dependencies as zcash to avoid dupicates.
In 5.1.0, zcash uses cxxbridge to generate bindings in build time, which means that we must do the same. This is not ideal since we must re-do the work that
zcashalready does when compiling, but the alternative would be to buildzcashwhile building this crate which is even more awkward. The long-term solution would be to move this crate tozcash/zcash, which we can consider later.