Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra dependency update steps to the README #63

Merged
merged 6 commits into from
Feb 23, 2023
Merged

Add extra dependency update steps to the README #63

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4160bec
Add extra dependency update steps to the README
teor2345 Feb 23, 2023
44fd00d
Use correct dependency steps from Cargo.toml
teor2345 Feb 23, 2023
2b9d53a
Explain how to make new dependencies work
teor2345 Feb 23, 2023
117f06a
Simplify instructions
teor2345 Feb 23, 2023
3ff0806
Add "check all open PRs before releasing"
teor2345 Feb 23, 2023
288d57b
Add "run cargo-release" to the release instructions
teor2345 Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,12 @@ to include a lot of other stuff e.g. the orchard library.

1. Update `depend/zcash` with the latest tagged version of `zcashd`
2. Update `Cargo.toml` versions to match the versions used by the latest tagged version of `zcashd`, and its dependencies
3. Publish a new release
3. For dependencies that are shared with Zebra (but not `zcashd`), match the latest version in Zebra's [Cargo.lock](https://github.com/ZcashFoundation/zebra/blob/main/Cargo.lock):
- use `cargo tree --invert <crate>` to see if the crate is from `zcash_script` or another dependency
- see the list in [Cargo.toml](https://github.com/ZcashFoundation/zcash_script/blob/master/Cargo.toml#L69)
4. For new dependencies with a leading zero in their version (`0.x.y`), use a `>=` dependency [to make them automatically upgrade to match Zebra's dependencies](https://doc.rust-lang.org/cargo/reference/resolver.html#semver-compatibility)
5. Check all open PRs to see if they can be merged before the release
6. Publish a new release
teor2345 marked this conversation as resolved.
Show resolved Hide resolved

### Updating `depend/zcash`

Expand Down