Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.1.13 release #91

Merged
merged 11 commits into from
Jul 7, 2023
Merged

v0.1.13 release #91

merged 11 commits into from
Jul 7, 2023

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Jun 27, 2023

Motivation

We need to update zcash_script's C++ and Rust dependencies.

This is still missing the version bumps.

Part of ZcashFoundation/zebra#7071.

@arya2 arya2 self-assigned this Jun 27, 2023
@arya2
Copy link
Contributor Author

arya2 commented Jun 27, 2023

cargo:warning=In file included from depend/zcash/src/zcash/NoteEncryption.hpp:13,
cargo:warning= from depend/zcash/src/primitives/transaction.h:22,
cargo:warning= from depend/zcash/src/script/zcash_script.cpp:10:
cargo:warning=depend/zcash/src/zcash/memo.h:8:10: fatal error: tl/expected.hpp: No such file or directory
cargo:warning= 8 | #include <tl/expected.hpp>

https://github.com/ZcashFoundation/zcash_script/actions/runs/5393931206/jobs/9794369997?pr=91#step:4:651

zcash/zcash#6716

@arya2 arya2 requested a review from conradoplg June 27, 2023 19:47
@conradoplg
Copy link
Contributor

Do you need help making this build?

I added the expected.hpp, luckily it seems just a header-only library. But we need to update the zcash_script instructions with how to update it (basically get the version pointed to in ./zcash/depends/packages/tl_expected.mk and copy the header to depend/expected/include/tl/expected.hpp. Or we could use subtree to include the library, but seems overkill.

But there is still another build issue, which seem to be related to crate versions discrepancy. Let me know if you need more help.

@arya2
Copy link
Contributor Author

arya2 commented Jun 29, 2023

Do you need help making this build?

Yes please.

@conradoplg
Copy link
Contributor

Do you need help making this build?

Yes please.

I think I got it working!

@arya2 arya2 requested a review from teor2345 June 29, 2023 22:05
teor2345
teor2345 previously approved these changes Jul 4, 2023
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

Let's release it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade zcash_script to the latest ECC code & dependencies, and release the crate
3 participants