Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: teor <teor@riseup.net>
Co-authored-by: Arya <aryasolhi@gmail.com>
  • Loading branch information
3 people committed Oct 17, 2023
1 parent ed9aafe commit 99503ec
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 11 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/cd-deploy-nodes-gcp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ jobs:

# Test that Zebra works using the default config with the latest Zebra version.
test-configuration-file:
name: Test Zebra default Docker config file
name: Test CD default Docker config file
needs: build
uses: ./.github/workflows/sub-test-zebra-config.yml
with:
Expand All @@ -107,9 +107,9 @@ jobs:
test_variables: '-e NETWORK'
network: 'Mainnet'

# Test reconfiguring the the docker image for tesnet.
# Test reconfiguring the docker image for testnet.
test-configuration-file-testnet:
name: Test Zebra testnet Docker config file
name: Test CD testnet Docker config file
needs: build
# Make sure Zebra can sync the genesis block on testnet
uses: ./.github/workflows/sub-test-zebra-config.yml
Expand All @@ -121,7 +121,7 @@ jobs:

# Test that Zebra works using $ZEBRA_CONF_PATH config
test-zebra-conf-path:
name: Test Zebra custom Docker config file
name: Test CD custom Docker config file
needs: build
uses: ./.github/workflows/sub-test-zebra-config.yml
with:
Expand Down Expand Up @@ -150,7 +150,7 @@ jobs:
matrix:
network: [Mainnet, Testnet]
name: Deploy ${{ matrix.network }} nodes
needs: [ build, versioning, test-configuration-file, test-configuration-file-testnet, test-zebra-conf-path ]
needs: [ build, versioning, test-configuration-file, test-zebra-conf-path ]
runs-on: ubuntu-latest
timeout-minutes: 60
permissions:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci-unit-tests-docker.patch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,13 @@ jobs:
- run: 'echo "No build required"'

test-configuration-file:
name: Test Zebra default Docker config file
name: Test CI default Docker config file
runs-on: ubuntu-latest
steps:
- run: 'echo "No build required"'

test-zebra-conf-path:
name: Test Zebra custom Docker config file
name: Test CI custom Docker config file
runs-on: ubuntu-latest
steps:
- run: 'echo "No build required"'
6 changes: 3 additions & 3 deletions .github/workflows/ci-unit-tests-docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ jobs:

# Test that Zebra works using the default config with the latest Zebra version.
test-configuration-file:
name: Test default config file
name: Test CI default Docker config file
needs: build
uses: ./.github/workflows/sub-test-zebra-config.yml
with:
Expand All @@ -220,7 +220,7 @@ jobs:

# Test reconfiguring the the docker image for tesnet.
test-configuration-file-testnet:
name: Test testnet config file
name: Test CI testnet Docker config file
needs: build
# Make sure Zebra can sync the genesis block on testnet
uses: ./.github/workflows/sub-test-zebra-config.yml
Expand All @@ -233,7 +233,7 @@ jobs:

# Test that Zebra works using $ZEBRA_CONF_PATH config
test-zebra-conf-path:
name: Test custom config file
name: Test CI custom Docker config file
needs: build
uses: ./.github/workflows/sub-test-zebra-config.yml
with:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/ci-unit-tests-os.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ on:
- '**/clippy.toml'
# workflow definitions
- '.github/workflows/ci-unit-tests-os.yml'
- '.github/workflows/sub-build-docker-image.yml'

push:
branches:
Expand Down

0 comments on commit 99503ec

Please sign in to comment.