Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Arya <aryasolhi@gmail.com>
  • Loading branch information
upbqdn and arya2 committed Jun 24, 2024
1 parent 76aeca5 commit b60d2de
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org).
but only feature flags instead.
- Fixed a bug with trailing characters in the openapi spec method descriptions ([#8597](https://github.com/ZcashFoundation/zebra/pull/8597))
- Added default constructions for several RPC method responses([#8616](https://github.com/ZcashFoundation/zebra/pull/8616))
- Zebra now drops transactions with unpaid actions.
- Zebra now drops transactions with unpaid actions in block templates and from the mempool.

## [Zebra 1.7.0](https://github.com/ZcashFoundation/zebra/releases/tag/v1.7.0) - 2024-05-07

Expand Down
5 changes: 3 additions & 2 deletions zebra-chain/src/transaction/unmined/zip317.rs
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,9 @@ pub fn mempool_checks(
//

Check failure on line 205 in zebra-chain/src/transaction/unmined/zip317.rs

View workflow job for this annotation

GitHub Actions / Rustfmt

Diff in /home/runner/work/zebra/zebra/zebra-chain/src/transaction/unmined/zip317.rs
// ## Note
//
// If the check above, which checks the number of unpaid actions, doesn't fail, then there is no
// way for the legacy check below to fail. This renders the legacy check redundant.
// If the check above for the maximum number of unpaid actions passes with the default
// unpaid action limit, then there is no way for the legacy check below to fail.
// This renders the legacy check redundant with the default unpaid action limit of 0.

const KILOBYTE: usize = 1000;

Expand Down

0 comments on commit b60d2de

Please sign in to comment.