Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Marek <mail@marek.onl>
  • Loading branch information
arya2 and upbqdn committed Jun 27, 2024
1 parent 78fff82 commit ce27a78
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion zebra-chain/src/parameters/network.rs
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ impl Network {
/// Mandatory checkpoints are a Zebra-specific feature.
/// If a Zcash consensus rule only applies before the mandatory checkpoint,
/// Zebra can skip validation of that rule.
///
/// This is necessary because Zebra can't fully validate the blocks prior to Canopy.
// TODO:
// - Support constructing pre-Canopy coinbase tx and block templates and return `Height::MAX` instead of panicking
// when Canopy activation height is `None` (#8434)
Expand Down
4 changes: 1 addition & 3 deletions zebra-chain/src/parameters/network/tests/prop.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,8 @@ use crate::{

proptest! {
/// Check that the mandatory checkpoint is immediately before Canopy activation.
///
/// This is necessary because Zebra can't fully validate the blocks prior to Canopy.
#[test]
fn mandatory_checkpoint_is_after_canopy(network in any::<Network>()) {
fn mandatory_checkpoint_is_immediately_before_canopy(network in any::<Network>()) {
let _init_guard = zebra_test::init();

let pre_canopy_activation = NetworkUpgrade::Canopy
Expand Down

0 comments on commit ce27a78

Please sign in to comment.