Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test translation for zebra-network::{Request, Response} protocol #1048

Closed
1 of 4 tasks
hdevalence opened this issue Sep 10, 2020 · 1 comment
Closed
1 of 4 tasks

Test translation for zebra-network::{Request, Response} protocol #1048

hdevalence opened this issue Sep 10, 2020 · 1 comment
Labels
A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement

Comments

@hdevalence
Copy link
Contributor

hdevalence commented Sep 10, 2020

Is your feature request related to a problem? Please describe.

We need to complete the translation layer between Bitcoin messages and zebra_network::{Request, Response} pairs.

Describe the solution you'd like

  • Each Message variant should generate a zebra_network::Request, or be explicitly ignored. Each zebra_network::Response variant should generate a Message, or in the case of Response::Nil, generate no message. (Done in Message/Request translation #1075)

  • Refactor the Zebra requests and response state into distinct request/response pairs (Refactor zebra-network Bitcoin to Zebra protocol translation layer #1515)

  • The translation should be tested by connecting two connection state machines and seeing that they translate back and forth correctly.

  • The translation should be tested against zcashd, as much as possible

Some of this work was implemented a long time ago, and some of it was implemented in #1016. The rest is to be completed.

Prerequisite for actually handling the requests in #889.

@hdevalence hdevalence added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Sep 10, 2020
@hdevalence hdevalence self-assigned this Sep 10, 2020
@hdevalence hdevalence added A-rust Area: Updates to Rust code E-med and removed S-needs-triage Status: A bug report needs triage labels Sep 10, 2020
@teor2345 teor2345 added this to the Sync and Network milestone Sep 29, 2020
@teor2345 teor2345 changed the title Fill in zebra-network::{Request, Response} protocol and test translation. Test translation for zebra-network::{Request, Response} protocol Dec 14, 2020
@mpguerra mpguerra removed this from the Sync and Network milestone Jan 5, 2021
@mpguerra mpguerra removed the E-med label Mar 23, 2021
@teor2345
Copy link
Collaborator

teor2345 commented May 3, 2022

We have implemented the network protocol, and have partial tests between two zebra-network instances.

We should open more specific tickets for missing tests, or just do them as we modify the protocol.

@teor2345 teor2345 closed this as completed May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement
Projects
None yet
Development

No branches or pull requests

3 participants