Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove our TracingComponent once functionality is upstreamed. #108

Closed
hdevalence opened this issue Nov 19, 2019 · 3 comments
Closed

Remove our TracingComponent once functionality is upstreamed. #108

hdevalence opened this issue Nov 19, 2019 · 3 comments

Comments

@hdevalence
Copy link
Contributor

Upstream issues: iqlusioninc/abscissa#149 iqlusioninc/abscissa#154

Once these are merged, we should update our Abscissa version #89 and remove our TracingComponent, or at least the part of it that does the tracing-related parts -- we probably want to keep the HTTP endpoint until we can fold it into an RPC mechanism.

@hdevalence
Copy link
Contributor Author

hdevalence commented Dec 5, 2019

This is merged upstream (but not released), so we can remove the tracing setup parts of the TracingComponent and change it to a TracingEndpoint that just feeds HTTP requests into the built-in tracing component.

Because these changes aren't released yet, this requires a temporary git dependency on abscissa, but it's probably good to test that the tracing component is actually usable and that there's not a hole in the API before asking for a release (cc @tarcieri).

@hdevalence
Copy link
Contributor Author

Looks like we can test this prerelease: iqlusioninc/abscissa#170

@hdevalence
Copy link
Contributor Author

Closed by #169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant