Iqlusioninc abscissa/v0.5 #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failed because I pulled out the branch from under it to rebase onto |
|
Hmm, actually it looks like there might be a problem with some GCloud thing rather than just the force-pushing 🤔 |
5 tasks
dconnolly
force-pushed
the
iqlusioninc-abscissa/v0.5
branch
from
c171ab2
to
be84104
Compare
|
This is failing because the tracing component is now outputting log information to a test that enforces that the version command only outputs the version string. |
The components are accessed by a lock on application state. When some command calls block_on to enter an async context, it obtained a write lock on the entire application state. This meant that if the application state were accessed later in an async context, a deadlock would occur. Instead the TokioComponent holds an Option<Runtime> now, so that before calling block_on, the caller can .take() the runtime and release the lock. Since we only ever enter an async context once, it's not a problem that the component is then missing its runtime, as once we are inside of a task we can access the runtime.
hdevalence
force-pushed
the
iqlusioninc-abscissa/v0.5
branch
from
5040070
to
1660f2c
Compare
|
I disabled the test because I don't want this to block on combining all of the tracing component configs with the zebrad configs. |
dconnolly
approved these changes
Jan 15, 2020
|
|
||
| /* | ||
| * Disabled pending tracing config rework, so that merging abscissa fixes doesn't block on this |
This was referenced Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #155 because I still don't know how to make "edits from maintainers" on GitHub....
This adds a single commit that fixes a deadlock in the
TokioComponent.The components are accessed by a lock on application state. When some command
calls block_on to enter an async context, it obtained a write lock on the
entire application state. This meant that if the application state were
accessed later in an async context, a deadlock would occur. Instead the
TokioComponent holds an Option now, so that before calling block_on,
the caller can .take() the runtime and release the lock. Since we only ever
enter an async context once, it's not a problem that the component is then
missing its runtime, as once we are inside of a task we can access the runtime.