Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the difficulty filter into a block::Header method #1445

Closed
teor2345 opened this issue Dec 3, 2020 · 1 comment
Closed

Move the difficulty filter into a block::Header method #1445

teor2345 opened this issue Dec 3, 2020 · 1 comment
Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup
Projects
🦓 Effort Affinity Grouping

Comments

@teor2345
Copy link
Collaborator

teor2345 commented Dec 3, 2020

Motivation

The difficulty filter check uses <=, and it's easy to get <= confused with <.

Solution

Move the difficulty filter into a block::Header method
@teor2345 teor2345 added A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup labels Dec 3, 2020
@teor2345 teor2345 added this to To Do in 🦓 via automation Dec 3, 2020
@teor2345 teor2345 mentioned this issue Dec 3, 2020
Closed
66 tasks
@mpguerra mpguerra added this to No Estimate in Effort Affinity Grouping Dec 18, 2020
@teor2345 teor2345 moved this from No Estimate to XXS - 1 in Effort Affinity Grouping Jan 11, 2021
@teor2345
Copy link
Collaborator Author

This is an API cleanup we might do eventually.

@teor2345 teor2345 added A-consensus Area: Consensus rule updates I-bad-code labels Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup
Projects
No open projects
Effort Affinity Grouping
XXS - 1
🦓
  
To Do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpguerra @teor2345