Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document consensus rules from Zcash spec: 7.4 Output Description Encoding and Consensus #3225

Closed
Tracked by #3125
mpguerra opened this issue Dec 14, 2021 · 1 comment · Fixed by #3462
Closed
Tracked by #3125

Document consensus rules from Zcash spec: 7.4 Output Description Encoding and Consensus #3225

mpguerra opened this issue Dec 14, 2021 · 1 comment · Fixed by #3462
Assignees
@conradoplg

Comments

@mpguerra
Copy link
Contributor

mpguerra commented Dec 14, 2021 •
edited
Loading

For each consensus rule:

  • check that the rule is implemented in Zebra
  • make sure the latest version of the rule is quoted in the docs for the code that implements it
  • make sure the code implements the latest version of the rule

Consensus rule

https://zips.z.cash/protocol/protocol.pdf#outputencodingandconsensus

Screenshot 2021-12-16 at 15 51 23

Implementation
@mpguerra mpguerra mentioned this issue Dec 14, 2021
Closed
50 tasks
@mpguerra mpguerra changed the title Document 7.4 Output Description Encoding and Consensus consensus rule Document consensus rules from Zcash spec: 7.4 Output Description Encoding and Consensus Dec 16, 2021
@conradoplg conradoplg mentioned this issue Feb 3, 2022
Merged
3 tasks
@conradoplg
Copy link
Contributor

I ended up doing this in #3462 since it was closely related

@teor2345 teor2345 assigned conradoplg and unassigned dconnolly Feb 3, 2022
@mergify mergify bot closed this as completed in #3462 Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@conradoplg conradoplg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: document consensus rules from 4.5 Output Descriptions ZcashFoundation/zebra
3 participants
@conradoplg @dconnolly @mpguerra