Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an NU5 block test vector that contains many shielded Sapling transactions #4775

Open
dconnolly opened this issue Jul 12, 2022 · 1 comment
Open

Add an NU5 block test vector that contains many shielded Sapling transactions #4775

dconnolly opened this issue Jul 12, 2022 · 1 comment
Labels
C-testing Category: These are tests I-slow Problems with performance or responsiveness
Projects
🦓

Comments

@dconnolly
Copy link
Contributor

Motivation

When blocks started showing up on mainnet after NU5 with many shielded Sapling transactions, we observed aberrant zebrad verification behavior. For similar blocks with many Orchard transactions, we identified some bugs already. We should include these blocks (at least one) as test vectors.

Related Work

#4774
@dconnolly dconnolly added S-needs-triage Status: A bug report needs triage P-Medium ⚡ I-slow Problems with performance or responsiveness C-testing Category: These are tests labels Jul 12, 2022
@dconnolly dconnolly added this to To Do in 🦓 via automation Jul 12, 2022
@dconnolly dconnolly mentioned this issue Jul 12, 2022
Open
@teor2345 teor2345 mentioned this issue Jul 28, 2022
Closed
@ftm1000 ftm1000 removed the S-needs-triage Status: A bug report needs triage label Aug 19, 2022
@teor2345
Copy link
Collaborator

Zebra's performance is good enough for now, so this is a low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-testing Category: These are tests I-slow Problems with performance or responsiveness
Projects
Zebra
Status: New
🦓
  
To Do
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dconnolly @mpguerra @teor2345 @ftm1000