Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve note commitment tree append performance #4841

Closed
teor2345 opened this issue Jul 28, 2022 · 1 comment
Closed

Improve note commitment tree append performance #4841

teor2345 opened this issue Jul 28, 2022 · 1 comment
Labels
A-cryptography Area: Cryptography related C-bug Category: This is a bug I-slow Problems with performance or responsiveness

Comments

@teor2345
Copy link
Contributor

teor2345 commented Jul 28, 2022

Motivation

Alfredo and I have been doing some timing tests on Zebra's CommitBlock and CommitFinalizedBlock state requests.

In some of my tests, Sapling note commitment tree appends were taking multiple seconds to run.
This is probably due to the large number of new Sapling notes in the chain.

We should try to improve performance of this code.

Suggested Changes

Add benchmarks for:

Once we have benchmarks, try to improve the performance of the code:

  • pass a vector to the append method, and do note commitment point conversions in parallel
  • inline the functions that are called when appending note commitment trees
@teor2345 teor2345 added C-bug Category: This is a bug S-needs-triage Status: A bug report needs triage P-High 🔥 I-slow Problems with performance or responsiveness A-cryptography Area: Cryptography related labels Jul 28, 2022
@teor2345
Copy link
Contributor Author

Performance improvements are a low priority for Zebra at the moment.

@teor2345 teor2345 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 26, 2022
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cryptography Area: Cryptography related C-bug Category: This is a bug I-slow Problems with performance or responsiveness
Projects
None yet
Development

No branches or pull requests

2 participants