Upgrade zebra-script for the zcashd 5.4.0 release

[teor2345]

Motivation

When zcashd 5.4.0 is released, we can upgrade the following dependency tree:

• zebra-script
  • zcash_script:
    • C++ code from zcashd
    • zcash_primitives 0.9 or 0.10
    • cxx 1.0.83

We might want to check that it compiles earlier, so we can remove any unnecessary zcashd dependencies or fix C++ compilation issues.

Testing

We have existing CI tests for all this code.

Related Work

We are upgrading Zebra's direct dependency on zcash_primitives to 0.10 in PR #6087.

[teor2345]

@mpguerra we might want to check that this upgrade works before ECC does their release, so we don't have to use forked versions of their crates or the zcashd code.

We don't have to do a full zcash_script release, just update the C++ code and dependencies and check it works. What do you think @conradoplg, is it worth it?

[conradoplg]

@mpguerra we might want to check that this upgrade works before ECC does their release, so we don't have to use forked versions of their crates or the zcashd code.

We don't have to do a full zcash_script release, just update the C++ code and dependencies and check it works. What do you think @conradoplg, is it worth it?

I think it's worth it, yes. Usually it's simple until it's not 😛

[teor2345]

Usually it's simple until it's not 😛

And I'd like to know that now while we can still ask them to fix things!

[mpguerra]

Hey team! Please add your planning poker estimate with Zenhub @arya2 @conradoplg @dconnolly @oxarbitrage @teor2345 @upbqdn

[teor2345]

We missed doing this before the release, so there might be some bugs we can't fix until their next release.

It would be good to have 3 people in the team who can work with zcash_script.
Conrado and I understand this code, maybe we could help someone else work on it?