Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(deps): Upgrade to the zcash_primitives 0.10 API #6087

Merged
merged 3 commits into from Feb 6, 2023

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Feb 1, 2023

Motivation

This upgrades to the latest versions of zcash_primitives and zcash_proofs.

Close #5978

Solution

Review

This is a routine dependency upgrade with some code changes.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added A-dependencies Area: Dependency file updates A-consensus Area: Consensus rule updates P-Medium ⚡ A-cryptography Area: Cryptography related labels Feb 1, 2023
@teor2345 teor2345 self-assigned this Feb 1, 2023
@teor2345 teor2345 requested review from a team as code owners February 1, 2023 22:36
@teor2345 teor2345 requested review from natalieesk and removed request for a team February 1, 2023 22:36
@github-actions github-actions bot added the C-enhancement Category: This is an improvement label Feb 1, 2023
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #6087 (5e410e7) into main (9d97919) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6087      +/-   ##
==========================================
+ Coverage   78.05%   78.13%   +0.07%     
==========================================
  Files         312      312              
  Lines       39421    39428       +7     
==========================================
+ Hits        30772    30806      +34     
+ Misses       8649     8622      -27     

@teor2345
Copy link
Contributor Author

teor2345 commented Feb 2, 2023

Hmm, this is a bit weird:

---- methods::tests::snapshot::test_rpc_response_data stdout ----
The application panicked (crashed).
Message: timeout while waiting for a request
in zebra_test::mock_service::MockService<zebra_node_services::mempool::Request, zebra_node_services::mempool::Response, zebra_test::mock_service::PanicAssertion, alloc::boxed::Box<dyn core::error::Error + core::marker::Send + core::marker::Sync>>
Location: /opt/zebrad/zebra-test/src/mock_service.rs:449

https://github.com/ZcashFoundation/zebra/actions/runs/4069659855/jobs/7010225007#step:3:2245

I'll try again.

mergify bot added a commit that referenced this pull request Feb 6, 2023
@mergify mergify bot merged commit 8c0176f into main Feb 6, 2023
@mergify mergify bot deleted the librustzcash-2023-02-02 branch February 6, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rule updates A-cryptography Area: Cryptography related A-dependencies Area: Dependency file updates C-enhancement Category: This is an improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to the zcash_primitives 0.10 API
2 participants