actions: use a name convention for workflow files/names #6166
Assignees
Labels
A-devops
Area: Pipelines, CI/CD and Dockerfiles
C-enhancement
Category: This is an improvement
I-usability
Zebra is hard to understand or use
S-needs-triage
Status: A bug report needs triage
Milestone
Comments
gustavovalverde
added
A-devops
|
hmm, we might want the first one to be |
6 tasks
mergify bot
pushed a commit
that referenced
this issue
Oct 18, 2023
* ref(workflows): consolidate workflows based on their purpose This also renames the workflows to make their naming more consistent and adding a naming convention Fixes: #6166 Fixes: #6167 * fix(workflows): use correct name for patch * fix(workflow): docker unit tests * fix(release): validation error Error: ``` Validation Failed: {"resource":"Release","code":"invalid","field":"target_commitish"} ``` Fixes: release-drafter/release-drafter#1125 * fix(workflows): reference correct name * fix: remove extra workflow * fix(workflows): use larger runners * fix(workflow): remove code already in docker unit-test * fix(unit-tests): start zebra the right way * fix: typo in patch name * chore: move job to logical order * imp(workflows): use better name for gcp tests * add: missing merge changes * chore: use better name for find-disks * fix(ci): use the `entrypoint.sh` to change the Network * fix(ci): add missing `ZEBRA_CONF_PATH` variable * fix(ci): allow to build the entrypoint file with testnet * fix(entrypoint): allow to create a dir and file with a single variable * refactor: test config file in CI and CD with a reusable workflow * fix(ci): wrong name used * fix(ci): use checkout * fix(ci): improve docker config tests * fix(ci): use better name for protection rules * Fix changed workflow file name in docs patch file * Apply suggestions from code review Co-authored-by: teor <teor@riseup.net> Co-authored-by: Arya <aryasolhi@gmail.com> * fix(cd): depend on file tests * fix(docs): adapt to new workflow name * fix: revert test coverage on CD * chore: reduce diff * fix(ci): allow using variable images for reusable workflows * fix(dockerfile): use variables or default for config path and file * fix(entrypoint): if `$ZEBRA_CONF_PATH` is set, do not override it * Fix patch job names and remove failure job testnet dependencies --------- Co-authored-by: teor <teor@riseup.net> Co-authored-by: Arya <aryasolhi@gmail.com>
mergify bot
pushed a commit
that referenced
this issue
Oct 19, 2023
* ref(workflows): consolidate workflows based on their purpose This also renames the workflows to make their naming more consistent and adding a naming convention Fixes: #6166 Fixes: #6167 * fix(workflows): use correct name for patch * fix(workflow): docker unit tests * fix(release): validation error Error: ``` Validation Failed: {"resource":"Release","code":"invalid","field":"target_commitish"} ``` Fixes: release-drafter/release-drafter#1125 * fix(workflows): reference correct name * fix: remove extra workflow * fix(workflows): use larger runners * fix(workflow): remove code already in docker unit-test * fix(unit-tests): start zebra the right way * fix: typo in patch name * chore: move job to logical order * imp(workflows): use better name for gcp tests * ref(workflow): use a single job to run GCP tests * fix(ci): do not format existing cached states if required * test: wait for the instance to be fully ready * fix(ci): use correct logic before formating * fix: use correct condition * fix: get more information * fix(ci): use better shell handling and upgrade OS * fix(ci): use better approach * fix: `$DISK_OPTION` is not being correctly passed * fix typo * fix: more typos * fix: use busybox * fix: mount Docker volume at run and not before * fix: use correct condition and simpler while * add: missing merge changes * chore: use better name for find-disks * fix(ci): use the `entrypoint.sh` to change the Network * fix(ci): add missing `ZEBRA_CONF_PATH` variable * fix(ci): considerate new updates to jobs * fix(ci): allow to build the entrypoint file with testnet * fix(entrypoint): allow to create a dir and file with a single variable * fix(ci): add missing jobs to `failure-issue` * Apply suggestions from code review Co-authored-by: teor <teor@riseup.net> * fix(ci): use better comment * refactor: test config file in CI and CD with a reusable workflow * fix(ci): wrong name used * fix(ci): use checkout * fix(ci): improve docker config tests * fix(ci): use better name for protection rules * chore: missing merge conflicts --------- Co-authored-by: teor <teor@riseup.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Motivation
We'd like to standardize the way the workflows are named, and align their names with what's actually being executed inside the workflow.
Specifications
When we do the redesign of Zebra CI, can we use a naming standard for workflow files?
For example, we could name them something like:
(purpose)-(when they run)-(where they run)-(what they do)-(patch?).ymlSo we'd end up with names like:
sub-build-docker-image.ymlci-pr-gcp-continuous-integration-test-docker.ymlci-pr-gh-continuous-integration-test-os.ymlcd-release-gcp-continuous-delivery-deploy-docker.ymlThe text was updated successfully, but these errors were encountered: