Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to run CI tests locally for developers #7534

Closed
oxarbitrage opened this issue Sep 12, 2023 · 0 comments · Fixed by #8209
Closed

Make it possible to run CI tests locally for developers #7534

oxarbitrage opened this issue Sep 12, 2023 · 0 comments · Fixed by #8209
Assignees

Comments

@oxarbitrage
Copy link
Contributor

oxarbitrage commented Sep 12, 2023

It will be nice that the developers could run a similar version of the Zebra upstream CI does on their local machines. There are several examples on why this will be a useful tool to have, some of them are:

  • There are changes that one could do to CI that will affect all the pull requests and other part of the systems. - For people that are not very familiar it is risky to experiment in the real live thing.
  • Sometimes i see changes to CI settings in PRs that are experiments, trying this or that. We could avoid this noise a bit by being able to test before pushing.
  • In general the developers don't use entrypoint.sh or docker to run tests locally which is what the CI does, we need a way to run the same thing both places so we can find certain problems easier.

I think we can assume that the developers has (or can easy obtain) an up to date zebra blockchain and a lightwalletd somewhere in the local hard drive.

This can maybe be done by just doing a tutorial, i am not sure, we can discuss more before doing anything.

Suggestions

  • Have a script to pass the ENV variables and/or arguments to run specific tests from CI, and be able to match each Rust test name from CI with the variables.
  • Change instructions in acceptance.rs to use the entrypoint.sh script to run tests
  • Make CI test IDs and Rust test names the same, pass the ID to the script instead of using environment variables
@teor2345 teor2345 changed the title Make it possible run CI tests locally for developers Make it possible to run CI tests locally for developers Sep 20, 2023
@arya2 arya2 self-assigned this Sep 27, 2023
@arya2 arya2 removed their assignment Oct 26, 2023
@mpguerra mpguerra linked a pull request Jan 30, 2024 that will close this issue
5 tasks
@mergify mergify bot closed this as completed in #8209 Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants