New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(docker): Consolidate all tests in the entrypoint.sh
script
#8175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavovalverde
added
A-devops
Area: Pipelines, CI/CD and Dockerfiles
C-enhancement
Category: This is an improvement
I-usability
Zebra is hard to understand or use
C-feature
Category: New features
P-Medium ⚡
labels
Jan 22, 2024
github-actions
bot
added
the
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
label
Jan 22, 2024
gustavovalverde
force-pushed
the
ref-docker-features
branch
from
January 22, 2024 17:19
b002465
to
09523ed
Compare
upbqdn
reviewed
Jan 22, 2024
oxarbitrage
added
do-not-merge
Tells Mergify not to merge this PR
and removed
do-not-merge
Tells Mergify not to merge this PR
labels
Jan 23, 2024
7 tasks
arya2
previously approved these changes
Jan 29, 2024
arya2
force-pushed
the
ref-docker-features
branch
from
January 29, 2024 22:24
15a2777
to
384dee7
Compare
arya2
reviewed
Jan 29, 2024
Co-authored-by: Arya <aryasolhi@gmail.com>
arya2
approved these changes
Jan 30, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-devops
Area: Pipelines, CI/CD and Dockerfiles
C-enhancement
Category: This is an improvement
C-feature
Category: New features
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
I-usability
Zebra is hard to understand or use
P-Medium ⚡
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There were some pending TODOs in CI of tests that were not available in out Docker
entrypoint.sh
, which allows more flexibility for running tests using environment variables.This had an impact on further implementations of #7534
This also sets some ground for #7892 and #7541
PR Author Checklist
Check before marking the PR as ready for review:
Complex Code or Requirements
run_cargo_test()
function could not be used.Solution
entrypoint.sh
EXPERIMENTAL_FEATURES
ARG and ENV to the Dockerfile, to allow the execution of tests with Experimental Features.Testing
Review
Anyone from DevOps. @upbqdn had an specific need for the TEST_FEATURES to be changed.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work
This will also allow to build the experimental docker image easier (more of that work in another PR)