Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(docker): Consolidate all tests in the entrypoint.sh script #8175

Merged
merged 6 commits into from Jan 30, 2024

Conversation

gustavovalverde
Copy link
Member

Motivation

There were some pending TODOs in CI of tests that were not available in out Docker entrypoint.sh, which allows more flexibility for running tests using environment variables.

This had an impact on further implementations of #7534
This also sets some ground for #7892 and #7541

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

Complex Code or Requirements

  • Not all tests are run with the same parameters, and the run_cargo_test() function could not be used.

Solution

  • Move the test execution from CI to the entrypoint.sh
  • Create new execution environment variables for missing tests
  • Add an EXPERIMENTAL_FEATURES ARG and ENV to the Dockerfile, to allow the execution of tests with Experimental Features.

Testing

  • Tests should give the same output, and also take a similar amount of time to run
  • We should confirm rebuilding is not happening on different tests (except, maybe, the Experimental one)

Review

Anyone from DevOps. @upbqdn had an specific need for the TEST_FEATURES to be changed.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Follow Up Work

This will also allow to build the experimental docker image easier (more of that work in another PR)

@gustavovalverde gustavovalverde added A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement I-usability Zebra is hard to understand or use C-feature Category: New features P-Medium ⚡ labels Jan 22, 2024
@gustavovalverde gustavovalverde self-assigned this Jan 22, 2024
@gustavovalverde gustavovalverde requested a review from a team as a code owner January 22, 2024 13:11
@gustavovalverde gustavovalverde requested review from arya2 and removed request for a team January 22, 2024 13:11
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Jan 22, 2024
docker/Dockerfile Outdated Show resolved Hide resolved
@oxarbitrage oxarbitrage added do-not-merge Tells Mergify not to merge this PR and removed do-not-merge Tells Mergify not to merge this PR labels Jan 23, 2024
@mpguerra mpguerra linked an issue Jan 24, 2024 that may be closed by this pull request
7 tasks
arya2
arya2 previously approved these changes Jan 29, 2024
docker/Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Arya <aryasolhi@gmail.com>
mergify bot added a commit that referenced this pull request Jan 30, 2024
@mergify mergify bot merged commit 184c30e into main Jan 30, 2024
133 checks passed
@mergify mergify bot deleted the ref-docker-features branch January 30, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-usability Zebra is hard to understand or use P-Medium ⚡
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

change(release): Enable all user features in the experimental build
4 participants