Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(mining): Enable mining RPCs by default in production builds #7740

Merged
merged 20 commits into from
Oct 18, 2023

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Oct 13, 2023

Post-Merge TODOs

  • Describe this newly stabilised feature in the CHANGELOG
  • Arborist announcement
  • Forum update

Motivation

We want to enable mining by default in production builds.

Close #7361
Depends-On: #7744

Solution

  • Enable the feature by default
  • Update the documentation to remove custom builds and docker images to enable the feature
  • Update the README to point to the Docker mining instructions
    • Consistently use ZF funding stream addresses in examples

Testing

  • Always set the miner address in tests based on the network

This is a very verbose change, but all it does is pass the network from all the tests down to the base test config method, then set the miner address for mainnet or testnet there.

Review

This is a pretty straightforward change. It doesn't matter which release it goes in.

I'd like extra documentation cleanups to go in another PR or ticket, that's what we're doing with test cleanups.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

Follow Up Work

These follow-up changes will be made in separate PRs:

@teor2345 teor2345 added P-Medium ⚡ A-rpc Area: Remote Procedure Call interfaces C-feature Category: New features labels Oct 13, 2023
@teor2345 teor2345 self-assigned this Oct 13, 2023
@teor2345 teor2345 requested a review from a team as a code owner October 13, 2023 03:04
@teor2345 teor2345 requested review from arya2 and removed request for a team October 13, 2023 03:04
@teor2345

This comment was marked as resolved.

@teor2345 teor2345 marked this pull request as draft October 13, 2023 03:33
@teor2345 teor2345 marked this pull request as ready for review October 13, 2023 04:05
@upbqdn upbqdn added the do-not-merge Tells Mergify not to merge this PR label Oct 13, 2023
@teor2345
Copy link
Contributor Author

Failed due to #7744, I restarted CI.

@teor2345 teor2345 changed the base branch from main to fix-lwd-send-tx October 15, 2023 23:23
@teor2345
Copy link
Contributor Author

It seems like the fix in PR #7744 might be needed for CI to pass reliably on this PR.

Base automatically changed from fix-lwd-send-tx to main October 17, 2023 02:56
arya2
arya2 previously approved these changes Oct 17, 2023
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, may need a rebase.

README.md Show resolved Hide resolved
book/src/user/mining.md Outdated Show resolved Hide resolved
zebra-rpc/src/config/mining.rs Show resolved Hide resolved
Co-authored-by: Arya <aryasolhi@gmail.com>
@upbqdn upbqdn removed the do-not-merge Tells Mergify not to merge this PR label Oct 17, 2023
mergify bot added a commit that referenced this pull request Oct 18, 2023
@mergify mergify bot merged commit 08ce2ad into main Oct 18, 2023
176 checks passed
@mergify mergify bot deleted the stable-gbt branch October 18, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Area: Remote Procedure Call interfaces C-feature Category: New features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make getblocktemplate-rpcs a default feature
3 participants