Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zebra-scan): Connect scanner with zebrad for block processing #7908

Closed
3 tasks
Tracked by #7728
oxarbitrage opened this issue Nov 3, 2023 · 8 comments
Closed
3 tasks
Tracked by #7728
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions C-feature Category: New features S-needs-triage Status: A bug report needs triage

Comments

@oxarbitrage
Copy link
Contributor

This task involves connecting the scanner task with zebrad, ensuring that it is initiated from within zebrad and that all incoming blocks are correctly routed to the scanner for processing.

To complete this task, we need to:

  • Integrate the scanner task into zebrad start command, ensuring it is triggered and operates in coordination with the zebrad node.
  • Verify that all incoming blocks within zebrad are sent to the scanner for further processing.
  • Do local testing to confirm the functionality of this integration.
@oxarbitrage oxarbitrage added the A-blockchain-scanner Area: Blockchain scanner of shielded transactions label Nov 3, 2023
@oxarbitrage oxarbitrage changed the title feat(zebra-scan): Connect scanner with zebrad for block processing. feat(zebra-scan): Connect scanner with zebrad for block processing Nov 3, 2023
@mpguerra mpguerra added C-feature Category: New features S-needs-triage Status: A bug report needs triage P-Medium ⚡ labels Nov 6, 2023
@teor2345
Copy link
Collaborator

teor2345 commented Nov 7, 2023

  • Verify that all incoming blocks within zebrad are sent to the scanner for further processing.

What about verified blocks that are already in Zebra's cached state? We also need to scan them with every key (and re-scan with each new key we get).

Can we open tickets to decide on a scanning strategy for cached blocks, and add that implementation in another scanner task?

(We want the incoming task to wait on new blocks, so it's tricky to have it handle cached blocks as well.)

@teor2345
Copy link
Collaborator

@mpguerra I think that running the scanner in zebrad needs to be part of the MVP.

@mpguerra
Copy link
Contributor

Hey team! Please add your planning poker estimate with Zenhub @arya2 @oxarbitrage @teor2345 @upbqdn

@mpguerra
Copy link
Contributor

It's not clear that this needs to be in the MVP, unscheduling

@teor2345
Copy link
Collaborator

teor2345 commented Nov 20, 2023

Are we going to run the scanner as a separate binary? That seems more complicated than running it from inside zebrad.

@teor2345
Copy link
Collaborator

As an alternative, we could remove "incoming blocks" from the scope of this ticket?

@upbqdn
Copy link
Member

upbqdn commented Nov 20, 2023

As an alternative, we could remove "incoming blocks" from the scope of this ticket?

We excluded #7905 from the MVP, so we should remove that item from the scope of this ticket.

@teor2345
Copy link
Collaborator

teor2345 commented Dec 4, 2023

This was done in PR #8040, except for some of the tests.

I moved the tests to #8022.

@teor2345 teor2345 closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions C-feature Category: New features S-needs-triage Status: A bug report needs triage
Projects
Archived in project
Development

No branches or pull requests

4 participants