Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sapling note commitment tree #1045

Merged
merged 11 commits into from Oct 6, 2020
Merged

Sapling note commitment tree #1045

merged 11 commits into from Oct 6, 2020

Conversation

dconnolly
Copy link
Contributor

@dconnolly dconnolly commented Sep 10, 2020 •
edited

Implementing part of #983

Resolves #286

@dconnolly dconnolly added NU-1 Sapling Network Upgrade: Sapling specific tasks NU Sprout Network Upgrade: Sprout specific tasks (before Overwinter) A-rust Area: Updates to Rust code labels Sep 10, 2020
@dconnolly dconnolly added this to the Validate transactions. milestone Sep 10, 2020
@dconnolly dconnolly requested a review from a team September 10, 2020 17:49
@dconnolly dconnolly added this to Review in progress in 🦓 via automation Sep 10, 2020
This was linked to issues Sep 10, 2020
Design Sprout note commitment trees. #36
Closed
Tracking: transaction validation #196
Closed
@dconnolly dconnolly changed the title Sprout and Sapling note commitment tree stuff [WIP] Sprout and Sapling note commitment tree stuff Sep 10, 2020
@dconnolly dconnolly changed the title [WIP] Sprout and Sapling note commitment tree stuff [WIP] Sprout and Sapling note commitment trees Sep 10, 2020
@dconnolly dconnolly changed the title [WIP] Sprout and Sapling note commitment trees Sprout and Sapling note commitment trees Sep 19, 2020
@dconnolly dconnolly marked this pull request as ready for review September 19, 2020 08:10
@dconnolly
Copy link
Contributor Author

Still pulling in some test vectors for Sprout but ready for api/style/structure review.

@dconnolly dconnolly mentioned this pull request Sep 24, 2020
Merged
@dconnolly dconnolly changed the title Sprout and Sapling note commitment trees Sapling note commitment tree Sep 25, 2020
@dconnolly dconnolly removed the NU Sprout Network Upgrade: Sprout specific tasks (before Overwinter) label Sep 25, 2020
@dconnolly dconnolly removed the request for review from a team September 25, 2020 18:30
yaahc
yaahc reviewed Sep 25, 2020
View reviewed changes
Copy link
Contributor

@yaahc yaahc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't really review the content of the crypto code but I left some comments on the general rust things. Happy to approve at any point

zebra-chain/src/sapling/commitment/pedersen_hashes.rs Show resolved Hide resolved
zebra-chain/src/sapling/tree.rs Show resolved Hide resolved
zebra-chain/src/sapling/tree.rs Show resolved Hide resolved
zebra-chain/src/sapling/tree.rs Outdated Show resolved Hide resolved
yaahc
yaahc reviewed Oct 5, 2020
View reviewed changes
Copy link
Contributor

@yaahc yaahc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good but I wouldn't mind a bit more explanation about how this works and how it should be used.

zebra-chain/src/sapling/tree.rs Outdated Show resolved Hide resolved
@dconnolly dconnolly requested a review from yaahc October 6, 2020 01:31
@dconnolly
Copy link
Contributor Author

I'm merging now but will be building on this to get an Incremental merkle tree with a sparse frontier that we can save down and retrieve from state in future work

@dconnolly dconnolly merged commit 5e18e72 into main Oct 6, 2020
🦓 automation moved this from Review in progress to Done Oct 6, 2020
@dconnolly dconnolly deleted the merkle branch October 6, 2020 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaahc yaahc yaahc approved these changes

@hdevalence hdevalence Awaiting requested review from hdevalence

@teor2345 teor2345 Awaiting requested review from teor2345

Assignees
No one assigned
Labels
A-rust Area: Updates to Rust code NU-1 Sapling Network Upgrade: Sapling specific tasks
Projects
No open projects
🦓
  
Done
Milestone
Transaction Validation
3 participants
@dconnolly @hdevalence @yaahc