Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete: Wake waiting tower-batch clones on close #1764

Merged
merged 3 commits into from
Feb 17, 2021
Merged

Incomplete: Wake waiting tower-batch clones on close #1764

merged 3 commits into from
Feb 17, 2021

Commits on Feb 17, 2021

  1. Wake waiting tower-batch tasks on drop 

    When other tower-batch tasks drop, wake any tasks that are waiting for
a semaphore permit. Otherwise, tower-batch can hang.

We currently pin tower in our workspace to:
d4d1c67 hedge: use auto-resizing histograms (tower-rs/tower#484)

Copy tower/src/semaphore.rs from that commit, to pick up
tower-rs/tower#480.
    @teor2345
    teor2345 committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    526ccfc View commit details
    Browse the repository at this point in the history

  2. Ignore clippy lints on copied code

    @teor2345
    teor2345 committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    36e174e View commit details
    Browse the repository at this point in the history

  3. Add a missing Sync bound

    @teor2345
    teor2345 committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    f670265 View commit details
    Browse the repository at this point in the history