Disable unreliable sync_large_checkpoints_testnet
#1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
requested changes
Feb 19, 2021
There was a problem hiding this comment.
Looks good, and it should work.
But I prefer to delete code, because it's easier to review the changes, and read the remaining code after the change.
So let's:
- replace the code with a short TODO comment, rather than commenting out the whole function
- open a ticket to revert this PR, and set it as blocked by Deploy more Zebra or zcashd instances on testnet #1222 (@mpguerra can help you do a "blocked by" relationship)
teor2345
added
A-rust
This was referenced Feb 19, 2021
2 tasks
|
Ok, done at 294f827 |
teor2345
reviewed
Feb 19, 2021
teor2345
approved these changes
Feb 19, 2021
This was referenced Feb 19, 2021
dconnolly
pushed a commit
that referenced
this pull request
Mar 10, 2021
This reverts commit bae49e5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Several pull requests fail the CI because the
sync_large_checkpoints_testnetare very unreliable.Solution
Disable the test until we have more testnet instances(#1222)
Review
Anyone can review.