Clean up block commitment enum and parsing #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change parses the hash, but does not perform validation.
- change Block::commitment to return a Result rather than an Option - enforce the all-zeroes reserved value consensus rules - change `PreSaplingReserved([u8; 32])` to `PreSaplingReserved` - change `ChainHistoryActivationReserved([u8; 32])` to `ChainHistoryActivationReserved` - update the function comments to describe when each variant is verified
teor2345
added
C-enhancement
|
I'm setting this to draft until #1957 merges. |
teor2345
changed the title
|
@oxarbitrage is busy, so pinging @dconnolly for this. |
dconnolly
reviewed
Mar 31, 2021
Comment on lines
+36
to
+39
| /// since Zebra checkpoints on Canopy, we don't need to validate this | ||
| /// field, but since it's included in the ChainHistoryRoot, we are | ||
| /// already calculating it, so we might as well validate it | ||
| FinalSaplingRoot(sapling::tree::Root), |
dconnolly
reviewed
Mar 31, 2021
|
|
||
| /// Errors that can occur when checking RootHash consensus rules. | ||
| /// | ||
| /// Each error variant corresponds to a consensus rule, so enumerating |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The goal of this PR is to finish the outstanding cleanups on the block commitment field from #881.
After they're done, we can create a good design for its
FinalSaplingRoot,ChainHistoryRoot, andBlockCommitmentsvariants.Solution
Saplingtree roots from other tree rootsNU5BlockCommitmentsHashvariant toblock::CommitmentBlock::commitmentThis PR is based on #1957.
Review
@oxarbitrage is going to work on ZIP-244 and ZIP-221 with me, so he can review this.
Related Issues
Closes #881
Makes some progress on #1874
Follow Up Work
Do a design for #1874, #1567, and #958