Benchmark Block struct serialization code

[fanatid]

Motivation

For resolving #1774 there should be a way to determine that improvement was introduced. Benchmark is a good way to see performance changes.
I do not think that it's required to benchmark all structs which implement ZcashSerialize. Block uses a lot (all?) of structs internally, so only Block should be enough.

Solution

Add a simple benchmark for the biggest block from zebra-test created with criterion.

Review

Related Issues

Should close #2019.

Follow Up Work

Create tracking issue for adding benchmarks to CI once this PR is merged.

[dconnolly]

Thanks for this PR! This will benchmark serialization of the largest block test vector we have, but not the messages we support yet, so we should create another issue and resolve that with this PR vs #1775.

And yes we should run all our benchmarks as part of CI, some of our dependencies (ed25519-zebra, redjubjub, bellman) have benchmarks for the batch verification of those signatures/proofs that we may want to run ourselves, or, repurpose them on top of the async services that leverage those batching implementations, and run those instead.

[teor2345]

👍

[teor2345]

Let's fix the hard-coded block name, and then we're good to merge.

You can also move the lexical-core change to #2026 if you want, but I don't want to block on that.

[teor2345]

Once CI passes, let's auto-merge this PR.

[fanatid]

😮 @teor2345 how you pushed 1761a5b to my fork?

[teor2345]

😮 @teor2345 how you pushed 1761a5b to my fork?

GitHub has an "allow maintainer updates" setting on PRs. It's on by default, and it lets maintainers push to your PR branch.

Sorry I should have asked first 🤭

(I always ask for permission for big changes.)

[fanatid]

😮 @teor2345 how you pushed 1761a5b to my fork?

GitHub has an "allow maintainer updates" setting on PRs. It's on by default, and it lets maintainers push to your PR branch.
Sorry I should have asked first 🤭
(I always ask for permission for big changes.)

wow, I thought this checkbox only for editing initial message. TIL 👍