Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop asking users to report peer errors, fix a common peer error #3054

Merged
merged 4 commits into from
Nov 15, 2021

Conversation

teor2345
Copy link
Contributor

Motivation

Zebra asks users to report peer errors, but there's nothing that Zebra developers can do to fix most of those errors.
This PR fixes one of the errors we can fix. #2107 should fix the rest.

This is unexpected work in sprint 22.

Solution

Closes #3052.

Review

Anyone can review this low-priority bug fix.

Reviewer Checklist

  • Code handles network messages correctly

This code needs to be refactored before we can unit test it. But it's tested by the zebrad acceptance tests.

Follow Up Work

@teor2345 teor2345 added C-bug Category: This is a bug P-Low I-usability Zebra is hard to understand or use A-network Area: Network protocol updates or fixes labels Nov 12, 2021
@teor2345 teor2345 added this to the 2021 Sprint 22 milestone Nov 12, 2021
@teor2345 teor2345 self-assigned this Nov 12, 2021
@zfnd-bot zfnd-bot bot added this to In progress in 🦓 Nov 12, 2021
@mpguerra mpguerra removed this from the 2021 Sprint 22 milestone Nov 15, 2021
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@oxarbitrage oxarbitrage merged commit 7457edc into main Nov 15, 2021
🦓 automation moved this from In progress to Done Nov 15, 2021
@oxarbitrage oxarbitrage deleted the inv-mixed-item-types-error branch November 15, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-network Area: Network protocol updates or fixes C-bug Category: This is a bug I-usability Zebra is hard to understand or use
Projects
No open projects
🦓
  
Done
Development

Successfully merging this pull request may close these issues.

Confusing error message: Remote peer sent an uninterpretable message: inv with mixed item types
3 participants