-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): Temporarily finish full sync at 99% #4457
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4457 +/- ##
==========================================
+ Coverage 78.88% 78.93% +0.05%
==========================================
Files 304 304
Lines 37285 37285
==========================================
+ Hits 29412 29432 +20
+ Misses 7873 7853 -20 |
It failed by a few minutes. I'm retrying it in case we got bad luck, but it seems we'll need to make it a bit faster, or change the percentage. |
The full sync completes, but the next step ( I was thinking on decoupling this task from the job, but then the instance will be kept alive indefinitely if the deletion step is not executed. I'm seeing if we can put a timer on the instance itself to auto-delete after 6h:30m |
I changed it to 99.2% for now |
This works, and it gives us the temporary speed increase we need, so I'm just going to merge it to unblock other PRs. We can revert it later. |
Motivation
As a workaround for #4456, we can just finish the full sync slightly early.
This removes coverage for:
But allows us to test lightwalletd.
Solution
Review
This PR is urgent because it blocks lightwalletd testing.
Reviewer Checklist
Follow Up Work
We should revert this change once #4456 is fixed.