Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine type for MAC #577

Merged
merged 1 commit into from Jul 2, 2020
Merged

Refine type for MAC #577

merged 1 commit into from Jul 2, 2020

Conversation

yaahc
Copy link
Contributor

@yaahc yaahc commented Jul 2, 2020

part of #123

@zfnd-bot zfnd-bot bot added this to In progress in 🦓 Jul 2, 2020
@yaahc yaahc requested a review from a team July 2, 2020 00:06
@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #577 into main will increase coverage by 2.59%.
The diff coverage is 60.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
+ Coverage   53.05%   55.65%   +2.59%     
==========================================
  Files          68       88      +20     
  Lines        3212     4088     +876     
==========================================
+ Hits         1704     2275     +571     
- Misses       1508     1813     +305     
Impacted Files Coverage Δ
tower-batch/src/error.rs 0.00% <0.00%> (ø)
tower-batch/src/layer.rs 0.00% <0.00%> (ø)
zebra-chain/src/block.rs 87.50% <ø> (+16.53%) ⬆️
zebra-chain/src/keys/sapling.rs 85.30% <ø> (ø)
zebra-chain/src/lib.rs 50.00% <ø> (ø)
zebra-chain/src/merkle_tree.rs 0.00% <ø> (ø)
zebra-chain/src/note_commitment_tree.rs 0.00% <ø> (ø)
zebra-chain/src/serde_helpers.rs 0.00% <0.00%> (ø)
zebra-chain/src/transaction.rs 16.66% <ø> (+16.66%) ⬆️
zebra-chain/src/transaction/joinsplit.rs 100.00% <ø> (+4.91%) ⬆️
... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8281b90...1912189. Read the comment docs.

🦓 automation moved this from In progress to Reviewer approved Jul 2, 2020
Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕺

zebra-chain/src/types.rs Show resolved Hide resolved
@yaahc yaahc merged commit c216f5c into main Jul 2, 2020
🦓 automation moved this from Reviewer approved to Done Jul 2, 2020
@yaahc yaahc deleted the mac branch July 2, 2020 00:57
dconnolly pushed a commit that referenced this pull request Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
🦓
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants