Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make logo fit 80 columns #7095

Merged
merged 1 commit into from Jun 28, 2023
Merged

fix: make logo fit 80 columns #7095

merged 1 commit into from Jun 28, 2023

Conversation

conradoplg
Copy link
Contributor

Motivation

The Zebra logo being shown was too large, making it wrap under 80 columns which is the default for many terminals.

Specifications

Complex Code or Requirements

Solution

I didn't notice the paste command I used to combine the Zebra logo and the heart was introducing a tab between them, so I just fixed that.

Closes #7074

Result:

Screenshot from 2023-06-28 11-59-08

Review

Trivial change, anyone can review.

In Ubuntu if you open a new terminal it will have 80 columns by default, I guess others are similar. Then just run Zebra with colors enabled, without redirecting stderr, and you should see the logo.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

Follow Up Work

@conradoplg conradoplg requested a review from a team as a code owner June 28, 2023 15:06
@conradoplg conradoplg requested review from oxarbitrage and removed request for a team June 28, 2023 15:06
@github-actions github-actions bot added the C-bug Category: This is a bug label Jun 28, 2023
@teor2345 teor2345 added P-Low ❄️ A-diagnostics Area: Diagnosing issues or monitoring performance labels Jun 28, 2023
@teor2345
Copy link
Contributor

Thanks!

@teor2345 teor2345 mentioned this pull request Jun 28, 2023
44 tasks
@mergify mergify bot merged commit 6ab451c into main Jun 28, 2023
323 checks passed
@mergify mergify bot deleted the fix-logo branch June 28, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Diagnosing issues or monitoring performance C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the Zebra logo fit in a standard 80 character terminal width
2 participants