Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(docs): Point to a manually created list of Zebra crates in docs #8160

Merged
merged 2 commits into from Jan 17, 2024

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Jan 16, 2024

Motivation

PR #7886 introduced this link to docs.rs for the docs of the public APIs: https://docs.rs/releases/search?query=zebra. However, the query in the link returns crates that are not part of the Zebra's public API and doesn't return the two tower-* crates that are part of Zebra.

This is a regular clean-up.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Is the documentation up to date?
For significant changes:
  • Is there a summary in the CHANGELOG?
  • Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

This PR refers to a manually created list of links pointing to the docs of the public APIs of all current Zebra crates.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

PR #7886 introduced this link to docs.rs for the docs of the public
APIs: https://docs.rs/releases/search?query=zebra. However, the query in
the link returns crates that are not part of the Zebra's public API,
and doesn't return the two tower-* crates that are part of Zebra.

This commit refers to a manually created list of links pointing to the
docs of the public APIs of all current Zebra crates.
@upbqdn upbqdn added C-bug Category: This is a bug A-docs Area: Documentation P-Low ❄️ labels Jan 16, 2024
@upbqdn upbqdn self-assigned this Jan 16, 2024
@upbqdn upbqdn requested a review from a team as a code owner January 16, 2024 22:34
@upbqdn upbqdn requested review from oxarbitrage and removed request for a team January 16, 2024 22:34
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mergify mergify bot merged commit 3ce5398 into main Jan 17, 2024
95 checks passed
@mergify mergify bot deleted the fix-crates-list-in-docs branch January 17, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants