Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(clippy): Remove an unnecessary vec! with cargo clippy --fix #8373

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Mar 22, 2024

Motivation

Cleanup of newly-stable clippy warning.

Close #8371.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?
For significant changes:
  • Is there a summary in the CHANGELOG?
  • Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

  • Removes the unnecessary vec!

Review

Anyone can review.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@arya2 arya2 added C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-High 🔥 labels Mar 22, 2024
@arya2 arya2 self-assigned this Mar 22, 2024
@arya2 arya2 requested a review from a team as a code owner March 22, 2024 01:48
@arya2 arya2 requested review from oxarbitrage and removed request for a team March 22, 2024 01:48
@github-actions github-actions bot added the extra-reviews This PR needs at least 2 reviews to merge label Mar 22, 2024
@oxarbitrage
Copy link
Contributor

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Mar 25, 2024

refresh

✅ Pull request refreshed

@oxarbitrage oxarbitrage removed the extra-reviews This PR needs at least 2 reviews to merge label Mar 25, 2024
@mergify mergify bot merged commit 949594c into main Mar 25, 2024
135 checks passed
@mergify mergify bot deleted the fix-clippy-warnings branch March 25, 2024 12:57
@arya2 arya2 mentioned this pull request Apr 15, 2024
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-High 🔥
Projects
None yet
Development

Successfully merging this pull request may close these issues.

main branch CI failed: push in Build crates individually
2 participants