Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update the PR template #8591

Merged
merged 9 commits into from
Jun 15, 2024
Merged

chore: Update the PR template #8591

merged 9 commits into from
Jun 15, 2024

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Jun 6, 2024

Motivation & Solution

I was going to edit the PR author's checklist so it mentions the changelog summary, and I ended up rewriting the whole PR template.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Is the documentation up to date?

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Follow Up Work

I will edit the release process docs to reflect the new changes around editing the changelog.

@upbqdn upbqdn added C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Low ❄️ labels Jun 6, 2024
@upbqdn upbqdn requested review from arya2 and oxarbitrage June 6, 2024 10:46
@upbqdn upbqdn self-assigned this Jun 6, 2024
@upbqdn upbqdn requested a review from a team as a code owner June 6, 2024 10:47
@upbqdn upbqdn requested a review from mpguerra June 6, 2024 10:47
mpguerra
mpguerra previously approved these changes Jun 7, 2024
@mergify mergify bot merged commit 8f27d97 into main Jun 15, 2024
95 checks passed
@mergify mergify bot deleted the refactor-pr-template branch June 15, 2024 14:28
@upbqdn upbqdn mentioned this pull request Jun 28, 2024
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Low ❄️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants